Skip to content

fix: Revert "feat: Enable CSP with nonce for Helix 5" #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

andreituicu
Copy link
Collaborator

Reverts #773

The current implementation does not work in cloudflare.

node_modules/@adobe/helix-html-pipeline/src/steps/csp.js:12:19: ERROR: Could not resolve "crypto"
node_modules/parse5-sax-parser/dist/dev-null-stream.js:1:25: ERROR: Could not resolve "node:stream"
node_modules/parse5-sax-parser/dist/index.js:1:26: ERROR: Could not resolve "node:stream"

@andreituicu andreituicu changed the title Revert "feat: Enable CSP with nonce for Helix 5" fix: Revert "feat: Enable CSP with nonce for Helix 5" Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (faa5e78) to head (c4e4f0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #815    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           46        45     -1     
  Lines         3895      3671   -224     
==========================================
- Hits          3895      3671   -224     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreituicu andreituicu merged commit 60924f0 into main Feb 11, 2025
9 checks passed
@andreituicu andreituicu deleted the revert-773-csp-nonce branch February 11, 2025 20:01
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
## [6.19.1](v6.19.0...v6.19.1) (2025-02-11)

### Bug Fixes

* Revert "feat: Enable CSP with nonce for Helix 5 ([#773](#773))" ([#815](#815)) ([60924f0](60924f0))
Copy link

🎉 This PR is included in version 6.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants